[dpdk-dev] RFC enabling dll/dso for dpdk on windows

[Thomas Monjalon]

09/07/2021 02:16, Tyler Retzlaff:
> On Thu, Jul 08, 2021 at 10:39:13PM +0200, Thomas Monjalon wrote:
> > 08/07/2021 21:21, Tyler Retzlaff:
> > > (2) importing exported data symbols from a dll/dso on windows requires
> > >     that the symbol be decorated with dllimport. optionally loading
> > >     performance of dll/dso is also further improved by decorating
> > >     exported function symbols. [3]
> > > 
> > > for (2) we would propose the introduction and use of two macros to
> > > allow decoration of exported data symbols. these macro would be or
> > > similarly named __rte_import and __rte_export. of note
> > 
> > That's the same symbol declared in a single place
> > which is exported and imported.
> > So I don't understand the need for 2 macros.
> 
> i may be misinterpreting your reply. you're saying there is no need for
> 2 because we use .def files?
> 
> strictly speaking when exporting C symbols this is true. so yes, we
> could introduce only __rte_import and not bother with __rte_export.
> 
> is that what you meant?
> 
> i don't have any objection to just __rte_import alone but it is
> mandatory for data symbols.

It may be my misunderstanding.
The function is declared only once in the .h
so I don't understand where these 2 macros are used.