[dpdk-dev] [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove
Zhang, Qi Z
qi.z.zhang at intel.com
Wed Oct 13 04:21:24 CEST 2021
> -----Original Message-----
> From: Zhang, RobinX <robinx.zhang at intel.com>
> Sent: Monday, October 11, 2021 4:13 PM
> To: dev at dpdk.org
> Cc: Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>;
> Guo, Junfeng <junfeng.guo at intel.com>; Yang, SteveX
> <stevex.yang at intel.com>; Zhang, RobinX <robinx.zhang at intel.com>
> Subject: [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove
>
> Firmware will return I40E_AQ_RC_ENOENT when try to delete non-existent
Better to add firmware version it should be 8.4+
> MAC/VLAN addresses from the HW filtering, this should not be considered as
> an Admin Queue error. But in i40e_asq_send_command, it will return
> I40E_ERR_ADMIN_QUEUE_ERROR if the return value of Admin Queue
> command processed by Firmware is not I40E_AQ_RC_OK or
> I40E_AQ_RC_EBUSY.
>
> Use i40e_aq_remove_macvlan_v2 instead so that we can get the
> corresponding Admin Queue status, and not report as an error in DPDK when
> Firmware return I40E_AQ_RC_ENOENT.
and it will not break with a old firmware
>
> Signed-off-by: Robin Zhang <robinx.zhang at intel.com>
Acked-by: Qi Zhang <qi.z.zhang at intel.com>
Applied to dpdk-next-net-intel after refine the commit log.
Thanks
Qi
More information about the dev
mailing list