[dpdk-dev] [PATCH v9 2/6] app/testpmd: dump device capability and Rx domain info

[Andrew Rybchenko]

On 10/19/21 12:10 PM, Xueming(Steven) Li wrote:
> On Tue, 2021-10-19 at 11:33 +0300, Andrew Rybchenko wrote:
>> On 10/19/21 11:17 AM, Xueming Li wrote:
>>> Dump device capability and Rx domain ID if shared Rx queue is supported
>>> by device.
>>>
>>> Signed-off-by: Xueming Li <xuemingl at nvidia.com>
>>
>> LGTM except one minor note:
>>
>> Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
>>
>>> ---
>>>  app/test-pmd/config.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>>> index 9c66329e96e..c0616dcd2fd 100644
>>> --- a/app/test-pmd/config.c
>>> +++ b/app/test-pmd/config.c
>>> @@ -733,6 +733,7 @@ port_infos_display(portid_t port_id)
>>>  	printf("Max segment number per MTU/TSO: %hu\n",
>>>  		dev_info.tx_desc_lim.nb_mtu_seg_max);
>>>  
>>> +	printf("Device capabilities: 0x%"PRIx64"\n", dev_info.dev_capa);
>>
>> IMHO, it should be decoded
> 
> Thanks for checking this, do you mean decode to readable names?
> Then we need a new API rte_eth_dev_capability_name(), it's simple, but
> is it ok to add API w/o RFC?

It is trivial. So, I think it should be OK.