[dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

[David Marchand]

On Wed, Sep 22, 2021 at 1:31 PM Xia, Chenbo <chenbo.xia at intel.com> wrote:
>
> > -----Original Message-----
> > From: Yigit, Ferruh <ferruh.yigit at intel.com>
> > Sent: Wednesday, September 22, 2021 5:27 PM
> > To: Xia, Chenbo <chenbo.xia at intel.com>; Burakov, Anatoly
> > <anatoly.burakov at intel.com>; dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent
> >
> > On 9/22/2021 4:30 AM, Xia, Chenbo wrote:
> > > Hi Anatoly,
> > >
> > >> -----Original Message-----
> > >> From: dev <dev-bounces at dpdk.org> On Behalf Of Anatoly Burakov
> > >> Sent: Thursday, September 16, 2021 6:37 PM
> > >> To: dev at dpdk.org
> > >> Subject: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent
> > >>
> > >> Currently, when VFIO support is not compiled, FreeBSD and Linux have
> > >> different return values. Fix Linux implementation to follow FreeBSD one.
> > >>
> > >> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> > >> ---
> > >>
> > >> Notes:
> > >>     Current minimum support Linux kernel is 4.4, and Meson build file sets
> > the
> > >
> > > Do you mean currently DPDK support linux >= 4.4? I am not aware of this,
> > could you
> > > show me where it is defined?
> > >
> >
> > https://git.dpdk.org/dpdk/tree/doc/guides/linux_gsg/sys_reqs.rst?h=v21.08#n124
> >
> > Commit d2feae68bf30 ("doc: update minimum supported Linux kernel")
>
> Thanks Ferruh!
>
> About removing the fallback or not, if we decide to remove, maybe for other files
> that check linux kernel version, we also need to change some check because we are
> assuming kernel version >= 4.4 here. If that's a strong requirement, I'll vote for
> yes...

>From those comments, it is unclear I can merge this series.
Anatoly?


Thanks.

-- 
David Marchand