[dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent
Burakov, Anatoly
anatoly.burakov at intel.com
Thu Oct 28 12:29:42 CEST 2021
Hi Chenbo,
> And do we need backport? As 'return -1' does not align with the API doxygen.
>
> Thanks,
> Chenbo
>
Maybe it's the FreeBSD implementation that needs to be adjusted then,
because none of those functions are valid on FreeBSD, and the
documentation for VFIO functions explicitly mentions that on FreeBSD,
they should return an error. I went with adjusting Linux implementation
to minimize the amount of changes we have to make (and only change code
path that no one uses in the first place), but maybe that was a wrong
decision.
I'm not sure if changing the API return value to match what was
documented counts as an API change, so maybe backport to stable is not
advised here.
--
Thanks,
Anatoly
More information about the dev
mailing list