[PATCH v6 26/26] net/spnic: fixes unsafe C style code

[Ferruh Yigit]

On 12/30/2021 6:09 AM, Yanling Song wrote:
> Use the hardware structure instead of void* as parameter of
> function to keep the type information

Hi Yanling,

This is a new driver and first patchset for it. Instead of fixing it in the set,
why not update old patches to introduce them correct at first place?

> 
> Signed-off-by: Yanling Song <songyl at ramaxel.com>
> ---
>   drivers/net/spnic/base/spnic_cmdq.c      |  14 +--
>   drivers/net/spnic/base/spnic_cmdq.h      |   6 +-
>   drivers/net/spnic/base/spnic_hw_cfg.c    |  49 ++++------
>   drivers/net/spnic/base/spnic_hw_cfg.h    |  16 ++--
>   drivers/net/spnic/base/spnic_hw_comm.c   |  32 ++++---
>   drivers/net/spnic/base/spnic_hw_comm.h   |  22 ++---
>   drivers/net/spnic/base/spnic_hwdev.c     |   8 +-
>   drivers/net/spnic/base/spnic_hwif.c      |  52 +++++------
>   drivers/net/spnic/base/spnic_hwif.h      |  22 ++---
>   drivers/net/spnic/base/spnic_mgmt.c      |   9 +-
>   drivers/net/spnic/base/spnic_mgmt.h      |   4 +-
>   drivers/net/spnic/base/spnic_nic_cfg.c   | 110 +++++++++++------------
>   drivers/net/spnic/base/spnic_nic_cfg.h   |  84 ++++++++---------
>   drivers/net/spnic/base/spnic_nic_event.c |  30 +++----
>   drivers/net/spnic/base/spnic_nic_event.h |  10 +--
>   drivers/net/spnic/base/spnic_wq.c        |   3 +-
>   drivers/net/spnic/base/spnic_wq.h        |   2 +-
>   drivers/net/spnic/spnic_ethdev.c         |  10 +--
>   drivers/net/spnic/spnic_io.c             |  34 +++----
>   drivers/net/spnic/spnic_io.h             |  10 +--
>   drivers/net/spnic/spnic_rx.c             |   4 +-
>   drivers/net/spnic/spnic_tx.c             |   4 +-
>   22 files changed, 252 insertions(+), 283 deletions(-)


<...>