[PATCH 8/8] vmxnet3: Fix merge error in initialization for rxDataRing feature

[Pankaj Gupta]

Hi Andrew,
Changes done in this patch was accidentally removed in commit 046f1161956777e3afb13504acbe8df2ec3a383c.
This was noticed later and we are trying to address this here.



Thanks,
Pankaj

From: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
Date: Wednesday, May 4, 2022 at 8:09 AM
To: Pankaj Gupta <pagupta at vmware.com>, Jochen Behrens <jbehrens at vmware.com>, Yong Wang <yongwang at vmware.com>
Cc: dev at dpdk.org <dev at dpdk.org>
Subject: Re: [PATCH 8/8] vmxnet3: Fix merge error in initialization for rxDataRing feature
⚠ External Email

On 5/3/22 07:22, Pankaj Gupta wrote:
> Fix merge error in initialization for rxDataRing feature.

Is it a bug fix? If so, it requires corresponding "Fixes:" tag and Cc to
stable at dpdk.org in order to be backported to stable releases.

>
> Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2.
>
> Signed-off-by: Pankaj Gupta <pagupta at vmware.com>
> ---
>   drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index 9955f121f6..6ced76ae2a 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -876,6 +876,11 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
>               rqd->conf.rxRingSize[1]   = rxq->cmd_ring[1].size;
>               rqd->conf.compRingSize    = rxq->comp_ring.size;
>
> +             if (VMXNET3_VERSION_GE_3(hw)) {
> +                     rqd->conf.rxDataRingBasePA = rxq->data_ring.basePA;
> +                     rqd->conf.rxDataRingDescSize = rxq->data_desc_size;
> +             }
> +
>               if (hw->intr.lsc_only)
>                       rqd->conf.intrIdx = 1;
>               else


________________________________

⚠ External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20220504/85d16ff5/attachment-0001.htm>