[PATCH v2 2/2] app/testpmd: register driver specific commands

Thomas Monjalon thomas at monjalon.net
Tue May 24 22:28:06 CEST 2022


24/05/2022 22:06, David Marchand:
> +	count = 0;
> +	for (i = 0; builtin_ctx[i] != NULL; i++, count++)
> +		;
> +	TAILQ_FOREACH(c, &driver_commands_head, next) {
> +		for (i = 0; c->commands[i].ctx != NULL; i++, count++)
> +			;
> +	}

Just a personal preference:
the iterator "i" is incremented inside the "for" instructions,
but I would have incremented "count" as a statement of the loops.

Acked-by: Thomas Monjalon <thomas at monjalon.net>

Thanks




More information about the dev mailing list