[PATCH v2 2/2] app/testpmd: register driver specific commands

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Tue May 31 17:14:49 CEST 2022


On 5/24/22 23:28, Thomas Monjalon wrote:
> 24/05/2022 22:06, David Marchand:
>> +	count = 0;
>> +	for (i = 0; builtin_ctx[i] != NULL; i++, count++)
>> +		;
>> +	TAILQ_FOREACH(c, &driver_commands_head, next) {
>> +		for (i = 0; c->commands[i].ctx != NULL; i++, count++)
>> +			;
>> +	}
> 
> Just a personal preference:
> the iterator "i" is incremented inside the "for" instructions,
> but I would have incremented "count" as a statement of the loops.

Since I dislike loops with empty body as well, I'll change it on
applying.

> 
> Acked-by: Thomas Monjalon <thomas at monjalon.net>
> 
> Thanks
> 
> 

Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>


More information about the dev mailing list