[PATCH v2 3/8] net/rnp: add device init and uninit

Stephen Hemminger stephen at networkplumber.org
Wed Aug 2 18:08:25 CEST 2023


On Wed,  2 Aug 2023 08:11:01 +0000
Wenbo Cao <caowenbo at mucse.com> wrote:

> +struct rnp_hw {
> +	void *back;
> +	char *iobar0;
> +	uint32_t iobar0_len;
> +	char *iobar4;
> +	uint32_t iobar4_len;

If possible, don't use untyped pointer for link list (back).
The iobar's should probably be void * or better yet map to
data structure.

Casts are often a source of bugs in C code.


More information about the dev mailing list