[PATCH v2 3/8] net/rnp: add device init and uninit

[11]

Thanks a lot, this problem that I have never been thought about it.

Regards Wenbo.
-----Original Message-----
From: Stephen Hemminger <stephen at networkplumber.org> 
Sent: 2023年8月3日 0:08
To: Wenbo Cao <caowenbo at mucse.com>
Cc: Anatoly Burakov <anatoly.burakov at intel.com>; dev at dpdk.org;
ferruh.yigit at intel.com; andrew.rybchenko at oktetlabs.ru
Subject: Re: [PATCH v2 3/8] net/rnp: add device init and uninit

On Wed,  2 Aug 2023 08:11:01 +0000
Wenbo Cao <caowenbo at mucse.com> wrote:

> +struct rnp_hw {
> +	void *back;
> +	char *iobar0;
> +	uint32_t iobar0_len;
> +	char *iobar4;
> +	uint32_t iobar4_len;

If possible, don't use untyped pointer for link list (back).
The iobar's should probably be void * or better yet map to data structure.

Casts are often a source of bugs in C code.