[PATCH v7 16/19] event/dlb2: use dedicated logtype
Stephen Hemminger
stephen at networkplumber.org
Mon Feb 5 23:04:25 CET 2024
On Mon, 5 Feb 2024 19:16:15 +0000
"Sevincer, Abdullah" <abdullah.sevincer at intel.com> wrote:
> >+ DLB2_LOG_INFO("Ignoring unsupported parameters when creating device '%s'",
> name);
>
> Hi Stephen can you modify above like this:
>
> DLB2_LOG_INFO(": Ignoring unsupported parameters when creating device '%s'\n",
> name);
>
> It looks better this way the output will be like this after this modification:
>
> dlb2_parse_params: Ignoring unsupported parameters when creating device 'ea:00.0'
I don't understand why you would say that.
The message already will get a single newline and your change would add a second one.
Log messages are not supposed to be double spaced, it confuses syslog.
If you want to change the overall format of log messages and how it displays the
function name, that is a different change. And would be done in the macro, DLB2_LOG_IMPL.
The focus of this patch set is using existing format, if you want to change that
please address it in another patch later.
More information about the dev
mailing list