[PATCH v7 16/19] event/dlb2: use dedicated logtype

Sevincer, Abdullah abdullah.sevincer at intel.com
Tue Feb 6 01:51:13 CET 2024


>+I don't understand why you would say that.
>+The message already will get a single newline and your change would add a second one.
>+Log messages are not supposed to be double spaced, it confuses syslog.

>+If you want to change the overall format of log messages and how it displays the function name, that is a different change. And would be done in the macro, DLB2_LOG_IMPL.
>+The focus of this patch set is using existing format, if you want to change that please address it in another patch later.

No need for new line, I copied wrong debug message, apologies it would be like this

DLB2_LOG_INFO(": Ignoring unsupported parameters when creating device '%s'",
				      name);

Note: Gage and Timothy is not with Intel now. So, not including them in the CC.




More information about the dev mailing list