[PATCH v2] net/netvsc: fix parsing of VLAN metadata

Alan Elder alan.elder at microsoft.com
Fri Feb 9 16:40:40 CET 2024


-----Original Message-----
From: Long Li <longli at microsoft.com> 
Sent: Friday, February 9, 2024 1:14 AM
To: stephen <stephen at networkplumber.org>; Alan Elder <alan.elder at microsoft.com>
Cc: dev at dpdk.org
Subject: RE: [PATCH v2] net/netvsc: fix parsing of VLAN metadata

> 
> Most of this driver came from FreeBSD. Did you look there to make sure 
> naming is the same. I.e would be good to be able to have same code in 
> both places as much as possible.

I hadn't looked, but have now - the FreeBSD code does not suffer from the same issue as it uses a series of MACROs to convert between formats.

Agree it seems sensible to keep the same code structure, so I will update the patch to follow the same style as FreeBSD code.


More information about the dev mailing list