[PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is missing
Tomasz Duszynski
tduszynski at marvell.com
Wed Jan 8 13:10:11 CET 2025
If HAVE_TCA_FLOWER is undefined compilation errors / warnings may
appear. This addresses following spotted issues:
../drivers/net/tap/rte_eth_tap.c:2113:1: error: label ‘disable_rte_flow’
defined but not used [-Werror=unused-label]
../drivers/net/tap/rte_eth_tap.c:1908:26: error: unused parameter
‘remote_iface’ [-Werror=unused-parameter]
Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
Cc: pascal.mazon at 6wind.com
Signed-off-by: Tomasz Duszynski <tduszynski at marvell.com>
---
drivers/net/tap/rte_eth_tap.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 650ddbd706..8fa708c58d 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1905,7 +1905,7 @@ static const struct eth_dev_ops ops = {
static int
eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,
- char *remote_iface, struct rte_ether_addr *mac_addr,
+ char *remote_iface __rte_unused, struct rte_ether_addr *mac_addr,
enum rte_tuntap_type type, int persist)
{
int numa_node = rte_socket_id();
@@ -2109,6 +2109,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,
rte_eth_dev_probing_finish(dev);
return 0;
+#ifdef HAVE_TCA_FLOWER
disable_rte_flow:
TAP_LOG(ERR, " Disabling rte flow support: %s(%d)",
strerror(errno), errno);
@@ -2118,6 +2119,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,
}
rte_eth_dev_probing_finish(dev);
return 0;
+#endif
#ifdef HAVE_TCA_FLOWER
error_remote:
--
2.34.1
More information about the dev
mailing list