[PATCH v8 27/29] lib/net: replace packed attributes

[Andre Muezerie]

On Wed, Jan 08, 2025 at 01:01:23PM +0100, David Marchand wrote:
> On Tue, Dec 31, 2024 at 7:40 PM Andre Muezerie
> <andremue at linux.microsoft.com> wrote:
> > diff --git a/lib/net/rte_ip6.h b/lib/net/rte_ip6.h
> > index 992ab5ee1f..92558a124a 100644
> > --- a/lib/net/rte_ip6.h
> > +++ b/lib/net/rte_ip6.h
> > @@ -358,7 +358,7 @@ enum rte_ipv6_mc_scope {
> >         RTE_IPV6_MC_SCOPE_ORGLOCAL = 0x08,
> >         /** Global multicast scope. */
> >         RTE_IPV6_MC_SCOPE_GLOBAL = 0x0e,
> > -} __rte_packed;
> > +};
> >
> >  /**
> >   * Extract the IPv6 multicast scope value as defined in RFC 4291, section 2.7.
> 
> Cc: Robin for info.
> 
> This change affects the storage size of a variable of this type (at
> least with gcc).
> I think it is ok from an ABI pov: there is one (inline) helper using
> this type, and nothing else in DPDK takes a IPv6 multicast scope as
> input.
> 
> However, it deserves a mention in the commitlog (maybe a separate
> commit to highlight it?).
> 
> 
> -- 
> David Marchand

Makes sense. I added a note about that to the commit message for that patch in the v10 series.

Thanks,
Andre Muezerie