[PATCH v2] net/nfp: fix uninit local var in nfp_pre_tun_table_check_del
Mark Bulatov
ms.bulatov7 at gmail.com
Mon Nov 16 18:18:56 CET 2026
If the search fails, it leads to a null pointer dereference when attempting
to initialize nfp_mac_idx.
Fix this by adding a check.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: d3c33bdf1f18 ("net/nfp: prepare for IPv4 UDP tunnel decap flow action")
Cc: stable at dpdk.org
Signed-off-by: Mark Bulatov <ms.bulatov7 at gmail.com>
---
v2 changes: Correction of the Fixes tag and addition of find_entry
initialization at the point of declaration
v1 link:
https://patches.dpdk.org/project/dpdk/patch/20261113142207.5537-1-ms.bulatov7@gmail.com/
drivers/net/nfp/flower/nfp_flower_flow.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c
index ad0fe9a8ef..2372d2fdb9 100644
--- a/drivers/net/nfp/flower/nfp_flower_flow.c
+++ b/drivers/net/nfp/flower/nfp_flower_flow.c
@@ -3793,7 +3793,7 @@ nfp_pre_tun_table_check_del(struct nfp_flower_representor *repr,
uint16_t nfp_mac_idx;
struct nfp_flow_priv *priv;
struct nfp_pre_tun_entry *entry;
- struct nfp_pre_tun_entry *find_entry;
+ struct nfp_pre_tun_entry *find_entry = NULL;
struct nfp_fl_rule_metadata *nfp_flow_meta;
priv = repr->app_fw_flower->flow_priv;
@@ -3828,6 +3828,13 @@ nfp_pre_tun_table_check_del(struct nfp_flower_representor *repr,
}
nfp_flow_meta = nfp_flow->payload.meta;
+
+ if (find_entry == NULL) {
+ PMD_DRV_LOG(ERR, "Pre-tunnel table search failed.");
+ ret = -EINVAL;
+ goto free_entry;
+ }
+
nfp_mac_idx = (find_entry->mac_index << 8) |
NFP_FLOWER_CMSG_PORT_TYPE_OTHER_PORT |
NFP_TUN_PRE_TUN_IDX_BIT;
--
2.39.5
More information about the dev
mailing list