[PATCH v2] net/nfp: fix uninit local var in nfp_pre_tun_table_check_del
Stephen Hemminger
stephen at networkplumber.org
Tue Nov 17 19:56:23 CET 2026
On Mon, 16 Nov 2026 20:18:56 +0300
Mark Bulatov <ms.bulatov7 at gmail.com> wrote:
> If the search fails, it leads to a null pointer dereference when attempting
> to initialize nfp_mac_idx.
>
> Fix this by adding a check.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: d3c33bdf1f18 ("net/nfp: prepare for IPv4 UDP tunnel decap flow action")
> Cc: stable at dpdk.org
>
> Signed-off-by: Mark Bulatov <ms.bulatov7 at gmail.com>
> ---
AI review had observations worth doing a cleanup pass to fix.
[PATCH 1/2] net/nfp: fix uninit local var in nfp_pre_tun_table_check_del
Info: the commit message covers only half of the bug.
find_entry can reach the dereference in two states. If no
pre_tun_bitmap[] slot is set, the loop body never runs and
find_entry is uninitialized. If slots are set but none matches,
find_entry holds the NULL from the last search. pre_tun_cnt counts
entries for all representors, so pre_tun_cnt > 1 does not mean
this representor's MAC is in the table. Suggested body:
find_entry is left uninitialized if no pre-tunnel slot is in
use, and is NULL if no slot matches this representor's MAC.
Either case is then dereferenced when computing nfp_mac_idx.
Initialize find_entry and fail the delete if no entry is found.
Info: put the check directly after the search loop.
The check sits after "nfp_flow_meta = nfp_flow->payload.meta;",
which has nothing to do with it. It reads better as part of the
search:
for (i = 1; i < NFP_TUN_PRE_TUN_RULE_LIMIT; i++) {
...
}
if (find_entry == NULL) {
PMD_DRV_LOG(ERR, "Pre-tunnel table entry not found.");
ret = -EINVAL;
goto free_entry;
}
nfp_flow_meta = nfp_flow->payload.meta;
More information about the dev
mailing list