[dpdk-stable] patch 'app/testpmd: fix memory leak for DSCP table' has been queued to stable release 18.08.1

Kevin Traynor ktraynor at redhat.com
Thu Nov 29 14:20:56 CET 2018


Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/08/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From c77be5d82097f4c82dc413ae4c7c7637d1960683 Mon Sep 17 00:00:00 2001
From: Jasvinder Singh <jasvinder.singh at intel.com>
Date: Wed, 14 Nov 2018 11:58:59 +0000
Subject: [PATCH] app/testpmd: fix memory leak for DSCP table

[ upstream commit 5fe5678de9c508332ea37d90a8267c3a2066219e ]

Fix memory leak for dscp table reported by coverity

Coverity issue: 326961
Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing")

Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
---
 app/test-pmd/cmdline_mtr.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index 846de88db..c506d87ee 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -1149,13 +1149,13 @@ static void cmd_set_port_meter_dscp_table_parsed(void *parsed_result,
 
 	if (port_id_is_invalid(port_id, ENABLED_WARN))
-		return;
+		goto free_table;
 
 	/* Update Meter DSCP Table*/
 	ret = rte_mtr_meter_dscp_table_update(port_id, mtr_id,
 		dscp_table, &error);
-	if (ret != 0) {
+	if (ret != 0)
 		print_err_msg(&error);
-		return;
-	}
+
+free_table:
 	free(dscp_table);
 }
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-29 13:11:36.465538824 +0000
+++ 0055-app-testpmd-fix-memory-leak-for-DSCP-table.patch	2018-11-29 13:11:34.000000000 +0000
@@ -1,13 +1,14 @@
-From 5fe5678de9c508332ea37d90a8267c3a2066219e Mon Sep 17 00:00:00 2001
+From c77be5d82097f4c82dc413ae4c7c7637d1960683 Mon Sep 17 00:00:00 2001
 From: Jasvinder Singh <jasvinder.singh at intel.com>
 Date: Wed, 14 Nov 2018 11:58:59 +0000
 Subject: [PATCH] app/testpmd: fix memory leak for DSCP table
 
+[ upstream commit 5fe5678de9c508332ea37d90a8267c3a2066219e ]
+
 Fix memory leak for dscp table reported by coverity
 
 Coverity issue: 326961
 Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing")
-Cc: stable at dpdk.org
 
 Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
 ---


More information about the stable mailing list