[dpdk-stable] patch 'app/pdump: fix port id storage size' has been queued to stable release 18.08.1

Kevin Traynor ktraynor at redhat.com
Thu Nov 29 14:20:57 CET 2018


Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/08/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From 0414a05cf4d929e35063c9842ccda5ab72a738bf Mon Sep 17 00:00:00 2001
From: Marko Kovacevic <marko.kovacevic at intel.com>
Date: Wed, 14 Nov 2018 08:56:45 +0000
Subject: [PATCH] app/pdump: fix port id storage size

[ upstream commit e772cf1bd0c10c13375d7de9acff842b76cb8f35 ]

port_id size should be uint16_t,
fix where it is defined as uint8_t

Fixes: f8244c6399d9 ("ethdev: increase port id range")

Signed-off-by: Marko Kovacevic <marko.kovacevic at intel.com>
Acked-by: Reshma Pattan <reshma.pattan at intel.com>
---
 app/pdump/main.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index ac2287124..af041feaa 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -120,6 +120,6 @@ struct pdump_tuples {
 	/* params for packet dumping */
 	enum pdump_by dump_by_type;
-	int rx_vdev_id;
-	int tx_vdev_id;
+	uint16_t rx_vdev_id;
+	uint16_t tx_vdev_id;
 	enum pcap_stream rx_vdev_stream_type;
 	enum pcap_stream tx_vdev_stream_type;
@@ -267,5 +267,5 @@ parse_pdump(const char *optarg)
 		if (ret < 0)
 			goto free_kvlist;
-		pt->port = (uint8_t) v.val;
+		pt->port = (uint16_t) v.val;
 		pt->dump_by_type = PORT_ID;
 	} else if (cnt2 == 1) {
@@ -436,5 +436,5 @@ disable_pdump(struct pdump_tuples *pt)
 
 static inline void
-pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
+pdump_rxtx(struct rte_ring *ring, uint16_t vdev_id, struct pdump_stats *stats)
 {
 	/* write input packets of port to vdev for pdump */
@@ -463,5 +463,5 @@ pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
 
 static void
-free_ring_data(struct rte_ring *ring, uint8_t vdev_id,
+free_ring_data(struct rte_ring *ring, uint16_t vdev_id,
 		struct pdump_stats *stats)
 {
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-29 13:11:36.488582808 +0000
+++ 0056-app-pdump-fix-port-id-storage-size.patch	2018-11-29 13:11:34.000000000 +0000
@@ -1,13 +1,14 @@
-From e772cf1bd0c10c13375d7de9acff842b76cb8f35 Mon Sep 17 00:00:00 2001
+From 0414a05cf4d929e35063c9842ccda5ab72a738bf Mon Sep 17 00:00:00 2001
 From: Marko Kovacevic <marko.kovacevic at intel.com>
 Date: Wed, 14 Nov 2018 08:56:45 +0000
 Subject: [PATCH] app/pdump: fix port id storage size
 
+[ upstream commit e772cf1bd0c10c13375d7de9acff842b76cb8f35 ]
+
 port_id size should be uint16_t,
 fix where it is defined as uint8_t
 
 Fixes: f8244c6399d9 ("ethdev: increase port id range")
-Cc: stable at dpdk.org
 
 Signed-off-by: Marko Kovacevic <marko.kovacevic at intel.com>
 Acked-by: Reshma Pattan <reshma.pattan at intel.com>
@@ -16,7 +17,7 @@
  1 file changed, 5 insertions(+), 5 deletions(-)
 
 diff --git a/app/pdump/main.c b/app/pdump/main.c
-index d96556ecf..9e86bf623 100644
+index ac2287124..af041feaa 100644
 --- a/app/pdump/main.c
 +++ b/app/pdump/main.c
 @@ -120,6 +120,6 @@ struct pdump_tuples {


More information about the stable mailing list