patch 'test/crypto: remove unnecessary stats retrieval' has been queued to stable release 20.11.4
Xueming Li
xuemingl at nvidia.com
Sun Nov 28 15:53:39 CET 2021
Hi,
FYI, your patch has been queued to stable release 20.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/30/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk
This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/8d0932f280f78fefac50f1f4478281a937004cde
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 8d0932f280f78fefac50f1f4478281a937004cde Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Thu, 11 Nov 2021 10:56:19 +0000
Subject: [PATCH] test/crypto: remove unnecessary stats retrieval
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit c0daf3bd4b4e36375f8c338092975d61ec03a98f ]
The device stats are retrieved in the testcase teardown function,
but are not being used afterwards. Remove this unnecessary call.
The stats retrieval for the device is being tested already by a
dedicated stats testcase.
Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
Signed-off-by: Ciara Power <ciara.power at intel.com>
Acked-by: Anoob Joseph <anoobj at marvell.com>
---
app/test/test_cryptodev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index a655c37a10..4dc2a597ff 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -954,7 +954,6 @@ ut_teardown(void)
{
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
- struct rte_cryptodev_stats stats;
/* free crypto session structure */
#ifdef RTE_LIB_SECURITY
@@ -1001,8 +1000,6 @@ ut_teardown(void)
RTE_LOG(DEBUG, USER1, "CRYPTO_MBUFPOOL count %u\n",
rte_mempool_avail_count(ts_params->mbuf_pool));
- rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats);
-
/* Stop the device */
rte_cryptodev_stop(ts_params->valid_devs[0]);
}
--
2.34.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-11-28 22:41:05.189960833 +0800
+++ 0035-test-crypto-remove-unnecessary-stats-retrieval.patch 2021-11-28 22:41:03.283541644 +0800
@@ -1 +1 @@
-From c0daf3bd4b4e36375f8c338092975d61ec03a98f Mon Sep 17 00:00:00 2001
+From 8d0932f280f78fefac50f1f4478281a937004cde Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit c0daf3bd4b4e36375f8c338092975d61ec03a98f ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org
@@ -21 +23 @@
-index ef0433680c..10b48cdadb 100644
+index a655c37a10..4dc2a597ff 100644
@@ -24 +26 @@
-@@ -1417,7 +1417,6 @@ ut_teardown(void)
+@@ -954,7 +954,6 @@ ut_teardown(void)
@@ -32 +34 @@
-@@ -1464,8 +1463,6 @@ ut_teardown(void)
+@@ -1001,8 +1000,6 @@ ut_teardown(void)
More information about the stable
mailing list