patch 'examples/l3fwd-power: fix early shutdown' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Sun Nov 28 15:53:40 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/30/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/e4f79de95a24b9d6030957cef4826623abd664f3

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From e4f79de95a24b9d6030957cef4826623abd664f3 Mon Sep 17 00:00:00 2001
From: Harneet Singh <harneet.singh at intel.com>
Date: Fri, 29 Oct 2021 14:05:56 +0000
Subject: [PATCH] examples/l3fwd-power: fix early shutdown
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 19781e7a038ac3fdae4d71904268daa6ee399001 ]

Currently, EAL init cannot be interrupted with SIGINT because the
signal handler is already overridden by the time EAL init happens.

Fix it by moving signal handler installation to after EAL
initialization, to allow SIGNIT to interrupt EAL initialization.

Fixes: d7937e2e3d12 ("power: initial import")
Fixes: 613ce6691c0d ("examples/l3fwd-power: implement proper shutdown")

Signed-off-by: Harneet Singh <harneet.singh at intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
---
 examples/l3fwd-power/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 43f14104a3..0cfcff7da0 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -2464,9 +2464,6 @@ main(int argc, char **argv)
 	uint16_t portid;
 	const char *ptr_strings[NUM_TELSTATS];
 
-	/* catch SIGINT and restore cpufreq governor to ondemand */
-	signal(SIGINT, signal_exit_now);
-
 	/* init EAL */
 	ret = rte_eal_init(argc, argv);
 	if (ret < 0)
@@ -2474,6 +2471,9 @@ main(int argc, char **argv)
 	argc -= ret;
 	argv += ret;
 
+	/* catch SIGINT and restore cpufreq governor to ondemand */
+	signal(SIGINT, signal_exit_now);
+
 	/* init RTE timer library to be used late */
 	rte_timer_subsystem_init();
 
-- 
2.34.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-28 22:41:05.239855636 +0800
+++ 0036-examples-l3fwd-power-fix-early-shutdown.patch	2021-11-28 22:41:03.286874917 +0800
@@ -1 +1 @@
-From 19781e7a038ac3fdae4d71904268daa6ee399001 Mon Sep 17 00:00:00 2001
+From e4f79de95a24b9d6030957cef4826623abd664f3 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 19781e7a038ac3fdae4d71904268daa6ee399001 ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index 6988a0ed34..b8b3be2b8a 100644
+index 43f14104a3..0cfcff7da0 100644
@@ -26 +28 @@
-@@ -2540,9 +2540,6 @@ main(int argc, char **argv)
+@@ -2464,9 +2464,6 @@ main(int argc, char **argv)
@@ -36 +38 @@
-@@ -2550,6 +2547,9 @@ main(int argc, char **argv)
+@@ -2474,6 +2471,9 @@ main(int argc, char **argv)


More information about the stable mailing list