patch 'net/mlx5/hws: fix range definer error recovery' has been queued to stable release 23.11.3

Xueming Li xuemingl at nvidia.com
Sat Dec 7 08:59:33 CET 2024


Hi,

FYI, your patch has been queued to stable release 23.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/10/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=40ea0017dda717772ee92e3d17c277425d18b64d

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 40ea0017dda717772ee92e3d17c277425d18b64d Mon Sep 17 00:00:00 2001
From: Gregory Etelson <getelson at nvidia.com>
Date: Sun, 27 Oct 2024 15:07:23 +0200
Subject: [PATCH] net/mlx5/hws: fix range definer error recovery
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 84c3090e517641027a7b64fe5bb6eccbcfa05a6d ]

Assign EINVAL to rte_errno when an invalid matcher range definition
is detected. This ensures the calling function is properly notified
about the error condition, which was previously not being reported.

Fixes: 9732ffe13bd6 ("net/mlx5/hws: add range definer creation")

Signed-off-by: Gregory Etelson <getelson at nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
---
 drivers/net/mlx5/hws/mlx5dr_definer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c
index daee2b6eb7..ef437a6dbd 100644
--- a/drivers/net/mlx5/hws/mlx5dr_definer.c
+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c
@@ -3221,6 +3221,7 @@ mlx5dr_definer_matcher_range_init(struct mlx5dr_context *ctx,

 		if (i && ((is_range && !has_range) || (!is_range && has_range))) {
 			DR_LOG(ERR, "Using range and non range templates is not allowed");
+			rte_errno = EINVAL;
 			goto free_definers;
 		}

--
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-12-06 23:26:44.658157620 +0800
+++ 0015-net-mlx5-hws-fix-range-definer-error-recovery.patch	2024-12-06 23:26:43.873044829 +0800
@@ -1 +1 @@
-From 84c3090e517641027a7b64fe5bb6eccbcfa05a6d Mon Sep 17 00:00:00 2001
+From 40ea0017dda717772ee92e3d17c277425d18b64d Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 84c3090e517641027a7b64fe5bb6eccbcfa05a6d ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 5c2e889444..5260830d9b 100644
+index daee2b6eb7..ef437a6dbd 100644
@@ -23 +25 @@
-@@ -4058,6 +4058,7 @@ mlx5dr_definer_matcher_range_init(struct mlx5dr_context *ctx,
+@@ -3221,6 +3221,7 @@ mlx5dr_definer_matcher_range_init(struct mlx5dr_context *ctx,


More information about the stable mailing list