patch 'common/dpaax/caamflib: enable fallthrough warnings' has been queued to stable release 22.11.7

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Nov 21 00:41:50 CET 2024


Hi,

FYI, your patch has been queued to stable release 22.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/22/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/50b8a025c8b23c5b6ffed29e29519ccd65908da3

Thanks.

Luca Boccassi

---
>From 50b8a025c8b23c5b6ffed29e29519ccd65908da3 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 14 Nov 2024 09:11:54 -0800
Subject: [PATCH] common/dpaax/caamflib: enable fallthrough warnings

[ upstream commit 277552e175b3529863adec9bbd8bb6288164506e ]

Fallthrough warnings catch real bugs and should not be disabled.
There are warnings in this driver in current build.

The commit that added the disable is old, and the problematic code
appears to have been already removed.

Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
 drivers/common/dpaax/caamflib/rta/operation_cmd.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/common/dpaax/caamflib/rta/operation_cmd.h b/drivers/common/dpaax/caamflib/rta/operation_cmd.h
index fe1ac37ee8..563735eb88 100644
--- a/drivers/common/dpaax/caamflib/rta/operation_cmd.h
+++ b/drivers/common/dpaax/caamflib/rta/operation_cmd.h
@@ -7,10 +7,6 @@
 #ifndef __RTA_OPERATION_CMD_H__
 #define __RTA_OPERATION_CMD_H__
 
-#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 70000)
-#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
-#endif
-
 extern enum rta_sec_era rta_sec_era;
 
 static inline int
-- 
2.45.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-11-20 23:41:23.584446094 +0000
+++ 0025-common-dpaax-caamflib-enable-fallthrough-warnings.patch	2024-11-20 23:41:22.752195468 +0000
@@ -1 +1 @@
-From 277552e175b3529863adec9bbd8bb6288164506e Mon Sep 17 00:00:00 2001
+From 50b8a025c8b23c5b6ffed29e29519ccd65908da3 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 277552e175b3529863adec9bbd8bb6288164506e ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list