patch 'app/procinfo: fix leak on exit' has been queued to stable release 22.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Nov 21 00:41:51 CET 2024
Hi,
FYI, your patch has been queued to stable release 22.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/22/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/0b010067c389479edb923a972584396da819d8d5
Thanks.
Luca Boccassi
---
>From 0b010067c389479edb923a972584396da819d8d5 Mon Sep 17 00:00:00 2001
From: Fidaullah Noonari <fidaullah.noonari at emumba.com>
Date: Thu, 3 Oct 2024 19:48:29 -0700
Subject: [PATCH] app/procinfo: fix leak on exit
[ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ]
When app is launched with -m proc-info exit without
rte_eal_cleanup() causing memory leakage. This commit resolves the
memory leakage issue and closes app properly.
Bugzilla ID: 898
Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit")
Fixes: 674bb3906931 ("app/procinfo: display eventdev xstats")
Signed-off-by: Fidaullah Noonari <fidaullah.noonari at emumba.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
---
app/proc-info/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 9104f9e6b9..8fd7ac945c 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1793,7 +1793,7 @@ main(int argc, char **argv)
if (mem_info) {
meminfo_display();
- return 0;
+ goto cleanup;
}
nb_ports = rte_eth_dev_count_avail();
@@ -1875,6 +1875,7 @@ main(int argc, char **argv)
RTE_ETH_FOREACH_DEV(i)
rte_eth_dev_close(i);
+cleanup:
ret = rte_eal_cleanup();
if (ret)
printf("Error from rte_eal_cleanup(), %d\n", ret);
--
2.45.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-11-20 23:41:23.612441016 +0000
+++ 0026-app-procinfo-fix-leak-on-exit.patch 2024-11-20 23:41:22.756195468 +0000
@@ -1 +1 @@
-From 8a171e52ed8b26f768ced79a22286914ebd30180 Mon Sep 17 00:00:00 2001
+From 0b010067c389479edb923a972584396da819d8d5 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -19,2 +20,2 @@
- app/proc-info/main.c | 5 +++--
- 1 file changed, 3 insertions(+), 2 deletions(-)
+ app/proc-info/main.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
@@ -23 +24 @@
-index 6886eb373a..e1272164b1 100644
+index 9104f9e6b9..8fd7ac945c 100644
@@ -26 +27 @@
-@@ -2171,11 +2171,11 @@ main(int argc, char **argv)
+@@ -1793,7 +1793,7 @@ main(int argc, char **argv)
@@ -34,4 +34,0 @@
- if (eventdev_xstats() > 0)
-- return 0;
-+ goto cleanup;
-
@@ -39,2 +36 @@
- if (nb_ports == 0)
-@@ -2256,6 +2256,7 @@ main(int argc, char **argv)
+@@ -1875,6 +1875,7 @@ main(int argc, char **argv)
More information about the stable
mailing list