patch 'net/gve: fix comma operator misuses' has been queued to stable release 25.11.3
Kevin Traynor
ktraynor at redhat.com
Thu Jul 23 19:14:33 CEST 2026
Hi,
FYI, your patch has been queued to stable release 25.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/27/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/c91a95015759ee6ce6db96a6239527eee93e7f0c
Thanks.
Kevin
---
>From c91a95015759ee6ce6db96a6239527eee93e7f0c Mon Sep 17 00:00:00 2001
From: Jasper Tran O'Leary <jtranoleary at google.com>
Date: Fri, 27 Mar 2026 00:18:24 +0000
Subject: [PATCH] net/gve: fix comma operator misuses
[ upstream commit ffa7353178363323c41249dd3ea37714d5809353 ]
The gve_adminq_create_rx_queue function initialized the admin queue
command using commas rather than semicolons after two fields'
initializations in the GQI queue format branch. Change these commas
to semicolons to remove the warning.
Fixes: f86e5ed86792 ("net/gve/base: introduce Google Virtual Ethernet base")
Signed-off-by: Jasper Tran O'Leary <jtranoleary at google.com>
Reviewed-by: Joshua Washington <joshwash at google.com>
---
drivers/net/gve/base/gve_adminq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/gve/base/gve_adminq.c b/drivers/net/gve/base/gve_adminq.c
index bc1759f006..b5b050d6d1 100644
--- a/drivers/net/gve/base/gve_adminq.c
+++ b/drivers/net/gve/base/gve_adminq.c
@@ -622,7 +622,7 @@ static int gve_adminq_create_rx_queue(struct gve_priv *priv, u32 queue_index)
cmd.create_rx_queue.rx_desc_ring_addr =
- cpu_to_be64(rxq->mz->iova),
+ cpu_to_be64(rxq->mz->iova);
cmd.create_rx_queue.rx_data_ring_addr =
- cpu_to_be64(rxq->data_mz->iova),
+ cpu_to_be64(rxq->data_mz->iova);
cmd.create_rx_queue.index = cpu_to_be32(queue_index);
cmd.create_rx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
--
2.55.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-23 17:57:58.999925145 +0100
+++ 0010-net-gve-fix-comma-operator-misuses.patch 2026-07-23 17:57:58.629884980 +0100
@@ -1 +1 @@
-From ffa7353178363323c41249dd3ea37714d5809353 Mon Sep 17 00:00:00 2001
+From c91a95015759ee6ce6db96a6239527eee93e7f0c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ffa7353178363323c41249dd3ea37714d5809353 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -18,2 +19 @@
- drivers/net/gve/meson.build | 1 -
- 2 files changed, 2 insertions(+), 3 deletions(-)
+ 1 file changed, 2 insertions(+), 2 deletions(-)
@@ -22 +22 @@
-index e4d06f58b0..9c5316fb00 100644
+index bc1759f006..b5b050d6d1 100644
@@ -25 +25 @@
-@@ -722,7 +722,7 @@ static int gve_adminq_create_rx_queue(struct gve_priv *priv, u32 queue_index)
+@@ -622,7 +622,7 @@ static int gve_adminq_create_rx_queue(struct gve_priv *priv, u32 queue_index)
@@ -35,8 +34,0 @@
-diff --git a/drivers/net/gve/meson.build b/drivers/net/gve/meson.build
-index 11560056b9..e93dd2e270 100644
---- a/drivers/net/gve/meson.build
-+++ b/drivers/net/gve/meson.build
-@@ -22,3 +22,2 @@ includes += include_directories('base')
-
- cflags += no_wvla_cflag
--cflags += no_comma_cflag
More information about the stable
mailing list