patch 'net/tap: avoid using Netlink socket if closed' has been queued to stable release 25.11.3
Kevin Traynor
ktraynor at redhat.com
Thu Jul 23 19:14:34 CEST 2026
Hi,
FYI, your patch has been queued to stable release 25.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/27/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/c8ecdf41ce32b3c76dada29c00bef5ba7442a85f
Thanks.
Kevin
---
>From c8ecdf41ce32b3c76dada29c00bef5ba7442a85f Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Fri, 3 Apr 2026 12:26:35 -0700
Subject: [PATCH] net/tap: avoid using Netlink socket if closed
[ upstream commit 3bdf8bcd272c56b0683f35226c292d8bbec08a14 ]
Coverity flagged that nlsk_fd could be negative when passed
to tap_nl_set_flags() during device close.
Coverity issue: 502576
Fixes: b5d76639551e ("net/tap: replace ioctl with Netlink")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Reviewed-by: Robin Jarry <rjarry at redhat.com>
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index fa09cd5ebf..5acb15affa 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1057,5 +1057,5 @@ tap_dev_close(struct rte_eth_dev *dev)
}
- if (internals->remote_if_index) {
+ if (internals->remote_if_index != 0 && internals->nlsk_fd != -1) {
/* Restore initial remote state */
int ret = tap_nl_set_flags(internals->nlsk_fd, internals->remote_if_index,
--
2.55.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-23 17:57:59.027418103 +0100
+++ 0011-net-tap-avoid-using-Netlink-socket-if-closed.patch 2026-07-23 17:57:58.629918644 +0100
@@ -1 +1 @@
-From 3bdf8bcd272c56b0683f35226c292d8bbec08a14 Mon Sep 17 00:00:00 2001
+From c8ecdf41ce32b3c76dada29c00bef5ba7442a85f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3bdf8bcd272c56b0683f35226c292d8bbec08a14 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index a5d460a0b3..ba9aef74c0 100644
+index fa09cd5ebf..5acb15affa 100644
@@ -23 +24 @@
-@@ -1125,5 +1125,5 @@ tap_dev_close(struct rte_eth_dev *dev)
+@@ -1057,5 +1057,5 @@ tap_dev_close(struct rte_eth_dev *dev)
More information about the stable
mailing list