patch 'net/iavf: keep device stopped if start fails' has been queued to stable release 24.11.9

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Nov 5 17:42:15 CET 2026


Hi,

FYI, your patch has been queued to stable release 24.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/07/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/116bc958d2d47fb7746d7d33bf100cdc25ea55c7

Thanks.

Luca Boccassi

---
>From 116bc958d2d47fb7746d7d33bf100cdc25ea55c7 Mon Sep 17 00:00:00 2001
From: Anatoly Burakov <anatoly.burakov at intel.com>
Date: Fri, 23 Oct 2026 10:32:21 +0100
Subject: [PATCH] net/iavf: keep device stopped if start fails

[ upstream commit bc69413284a96f55236a0305da34aaffb4b15d01 ]

Currently, `iavf_dev_start()` clears `adapter->stopped` before several
operations that can fail. A subsequent `iavf_dev_stop()` then disables
interrupts and stops and resets queues even though startup did not
complete.

Mark the adapter running only after startup succeeds, and return early
from stop when it is already stopped.

Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")

Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 8ec31b78789..b7476ba49f2 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1006,8 +1006,6 @@ iavf_dev_start(struct rte_eth_dev *dev)
 	if (adapter->closed)
 		return -1;
 
-	adapter->stopped = 0;
-
 	vf->max_pkt_len = dev->data->mtu + IAVF_ETH_OVERHEAD;
 	vf->num_queue_pairs = RTE_MAX(dev->data->nb_rx_queues,
 				      dev->data->nb_tx_queues);
@@ -1084,6 +1082,8 @@ iavf_dev_start(struct rte_eth_dev *dev)
 		goto error;
 	}
 
+	adapter->stopped = 0;
+
 	/* An explicit start supersedes any pending deferred start */
 	vf->start_pending = false;
 
@@ -1106,13 +1106,13 @@ iavf_dev_stop(struct rte_eth_dev *dev)
 	if (adapter->closed)
 		return -1;
 
+	if (adapter->stopped == 1)
+		return 0;
+
 	if (!(vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) &&
 	    dev->data->dev_conf.intr_conf.rxq != 0)
 		rte_intr_disable(intr_handle);
 
-	if (adapter->stopped == 1)
-		return 0;
-
 	/* Disable the interrupt for Rx */
 	rte_intr_efd_disable(intr_handle);
 	/* Rx interrupt vector mapping free */
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-11-05 16:42:46.838330263 +0000
+++ 0048-net-iavf-keep-device-stopped-if-start-fails.patch	2026-11-05 16:42:44.957061862 +0000
@@ -1 +1 @@
-From bc69413284a96f55236a0305da34aaffb4b15d01 Mon Sep 17 00:00:00 2001
+From 116bc958d2d47fb7746d7d33bf100cdc25ea55c7 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit bc69413284a96f55236a0305da34aaffb4b15d01 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -20,2 +21,2 @@
- drivers/net/intel/iavf/iavf_ethdev.c | 9 ++++-----
- 1 file changed, 4 insertions(+), 5 deletions(-)
+ drivers/net/iavf/iavf_ethdev.c | 10 +++++-----
+ 1 file changed, 5 insertions(+), 5 deletions(-)
@@ -23,5 +24,5 @@
-diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
-index a2be58f1a8..91851b06db 100644
---- a/drivers/net/intel/iavf/iavf_ethdev.c
-+++ b/drivers/net/intel/iavf/iavf_ethdev.c
-@@ -1039,8 +1039,6 @@ iavf_dev_start(struct rte_eth_dev *dev)
+diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
+index 8ec31b78789..b7476ba49f2 100644
+--- a/drivers/net/iavf/iavf_ethdev.c
++++ b/drivers/net/iavf/iavf_ethdev.c
+@@ -1006,8 +1006,6 @@ iavf_dev_start(struct rte_eth_dev *dev)
@@ -36 +37,2 @@
-@@ -1112,6 +1110,7 @@ iavf_dev_start(struct rte_eth_dev *dev)
+@@ -1084,6 +1082,8 @@ iavf_dev_start(struct rte_eth_dev *dev)
+ 		goto error;
@@ -39 +40,0 @@
- 	iavf_phc_sync_alarm_start(dev);
@@ -41 +42 @@
- 
++
@@ -44 +45,2 @@
-@@ -1135,13 +1134,13 @@ iavf_dev_stop(struct rte_eth_dev *dev)
+ 
+@@ -1106,13 +1106,13 @@ iavf_dev_stop(struct rte_eth_dev *dev)
@@ -58,2 +59,0 @@
- 	iavf_phc_sync_alarm_stop(dev);
- 
@@ -60,0 +61,2 @@
+ 	rte_intr_efd_disable(intr_handle);
+ 	/* Rx interrupt vector mapping free */


More information about the stable mailing list