patch 'net/iavf: fix false success on flow validation' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Nov 5 17:42:16 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/07/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/a19786538658385fa07820001bf9c635be6760ec
Thanks.
Luca Boccassi
---
>From a19786538658385fa07820001bf9c635be6760ec Mon Sep 17 00:00:00 2001
From: Anatoly Burakov <anatoly.burakov at intel.com>
Date: Fri, 23 Oct 2026 10:32:23 +0100
Subject: [PATCH] net/iavf: fix false success on flow validation
[ upstream commit fae5ce5de601e286ca009f4a3d914d5824df0337 ]
`iavf_parse_engine_validate()` sets an error when validation fails, but
then returns the engine pointer. `iavf_flow_process_filter()` treats a
non-NULL engine as success, so `rte_flow_validate()` can accept an
invalid flow.
Return `NULL` on validation failure and return the engine only after
validation succeeds.
Fixes: ff2d0c345c3b ("net/iavf: support generic flow API")
Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
drivers/net/iavf/iavf_generic_flow.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_generic_flow.c b/drivers/net/iavf/iavf_generic_flow.c
index 2ce5488cff9..ac928e03e7b 100644
--- a/drivers/net/iavf/iavf_generic_flow.c
+++ b/drivers/net/iavf/iavf_generic_flow.c
@@ -2166,10 +2166,11 @@ iavf_parse_engine_validate(struct iavf_adapter *ad,
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_HANDLE,
NULL, "Validation failed");
- break;
+ return NULL;
}
+ return engine;
}
- return engine;
+ return NULL;
}
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-11-05 16:42:46.874634308 +0000
+++ 0049-net-iavf-fix-false-success-on-flow-validation.patch 2026-11-05 16:42:44.957061862 +0000
@@ -1 +1 @@
-From fae5ce5de601e286ca009f4a3d914d5824df0337 Mon Sep 17 00:00:00 2001
+From a19786538658385fa07820001bf9c635be6760ec Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit fae5ce5de601e286ca009f4a3d914d5824df0337 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
- drivers/net/intel/iavf/iavf_generic_flow.c | 5 +++--
+ drivers/net/iavf/iavf_generic_flow.c | 5 +++--
@@ -23,5 +24,5 @@
-diff --git a/drivers/net/intel/iavf/iavf_generic_flow.c b/drivers/net/intel/iavf/iavf_generic_flow.c
-index 92ca20031c0..14242e6ebbb 100644
---- a/drivers/net/intel/iavf/iavf_generic_flow.c
-+++ b/drivers/net/intel/iavf/iavf_generic_flow.c
-@@ -2134,10 +2134,11 @@ iavf_parse_engine_validate(struct iavf_adapter *ad,
+diff --git a/drivers/net/iavf/iavf_generic_flow.c b/drivers/net/iavf/iavf_generic_flow.c
+index 2ce5488cff9..ac928e03e7b 100644
+--- a/drivers/net/iavf/iavf_generic_flow.c
++++ b/drivers/net/iavf/iavf_generic_flow.c
+@@ -2166,10 +2166,11 @@ iavf_parse_engine_validate(struct iavf_adapter *ad,
More information about the stable
mailing list