patch 'bus/dpaa: remove unused variable' has been queued to stable release 24.11.9

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Oct 27 12:48:45 CET 2026


Hi,

FYI, your patch has been queued to stable release 24.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/ee2bedacc3c0c50a866c967ae213a61ffc31a0a4

Thanks.

Luca Boccassi

---
>From ee2bedacc3c0c50a866c967ae213a61ffc31a0a4 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Sat, 29 Aug 2026 08:44:46 -0700
Subject: [PATCH] bus/dpaa: remove unused variable

[ upstream commit 030565d82a78b400a0be4dcdbc6561572d49857b ]

The driver was recording the clock frequency and never using it.

clang 23 reports:

  qman_driver.c:27:12: warning: variable 'qman_clk' set but not used
        [-Wunused-but-set-global]

Remove the variable and the dead store.

Fixes: f6fadc3e6310 ("bus/dpaa: add QMAN interface driver")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
Acked-by: David Marchand <david.marchand at redhat.com>
---
 drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c
index e01eb0bd46f..dafc4e439e4 100644
--- a/drivers/bus/dpaa/base/qbman/qman_driver.c
+++ b/drivers/bus/dpaa/base/qbman/qman_driver.c
@@ -23,8 +23,6 @@ u16 qm_channel_pme = QMAN_CHANNEL_PME;
 
 /* Ccsr map address to access ccsrbased register */
 static void *qman_ccsr_map;
-/* The qman clock frequency */
-static u32 qman_clk;
 
 static __thread int qmfd = -1;
 static __thread struct qm_portal_config qpcfg;
@@ -346,8 +344,6 @@ int qman_global_init(void)
 	clk = of_get_property(dt_node, "clock-frequency", NULL);
 	if (!clk)
 		pr_warn("Can't find Qman clock frequency\n");
-	else
-		qman_clk = be32_to_cpu(*clk);
 
 #ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
 	return qman_setup_fq_lookup_table(CONFIG_FSL_QMAN_FQ_LOOKUP_MAX);
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-10-27 11:43:54.949264912 +0000
+++ 0031-bus-dpaa-remove-unused-variable.patch	2026-10-27 11:43:53.526059820 +0000
@@ -1 +1 @@
-From 030565d82a78b400a0be4dcdbc6561572d49857b Mon Sep 17 00:00:00 2001
+From ee2bedacc3c0c50a866c967ae213a61ffc31a0a4 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 030565d82a78b400a0be4dcdbc6561572d49857b ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org
@@ -26 +27 @@
-index 45b094e0c65..bbe2640c529 100644
+index e01eb0bd46f..dafc4e439e4 100644
@@ -38 +39 @@
-@@ -371,8 +369,6 @@ int qman_global_init(void)
+@@ -346,8 +344,6 @@ int qman_global_init(void)


More information about the stable mailing list