patch 'net/qede: remove unused variable' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue Oct 27 12:48:46 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/f76ec6c9cc3d241d74b6154ec6eb2c03ce5e01dd
Thanks.
Luca Boccassi
---
>From f76ec6c9cc3d241d74b6154ec6eb2c03ce5e01dd Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Sat, 29 Aug 2026 08:44:48 -0700
Subject: [PATCH] net/qede: remove unused variable
[ upstream commit d497820350b9dda74ed622440efe704fc7f22a48 ]
qed_dbg_set_app_ver() validates the caller's version and stores it.
clang 23 reports:
qede_debug.c:820:12: warning: variable 's_app_ver' set but not used
[-Wunused-but-set-global]
Since the whole qed_dbg_set_app_ver() function is doing nothing
remove it.
Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: David Marchand <david.marchand at redhat.com>
---
drivers/net/qede/qede_debug.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c
index 1d3147b7248..d14ef93a3ca 100644
--- a/drivers/net/qede/qede_debug.c
+++ b/drivers/net/qede/qede_debug.c
@@ -812,13 +812,6 @@ static struct split_type_defs s_split_type_defs[] = {
{"vf"}
};
-/******************************** Variables *********************************/
-
-/**
- * The version of the calling app
- */
-static u32 s_app_ver;
-
/**************************** Private Functions ******************************/
/* Reads and returns a single dword from the specified unaligned buffer */
@@ -4864,16 +4857,6 @@ enum dbg_status qed_dbg_set_bin_ptr(struct ecore_hwfn *p_hwfn,
return DBG_STATUS_OK;
}
-enum dbg_status qed_dbg_set_app_ver(u32 ver)
-{
- if (ver < TOOLS_VERSION)
- return DBG_STATUS_UNSUPPORTED_APP_VERSION;
-
- s_app_ver = ver;
-
- return DBG_STATUS_OK;
-}
-
bool qed_read_fw_info(struct ecore_hwfn *p_hwfn,
struct ecore_ptt *p_ptt, struct fw_info *fw_info)
{
@@ -8087,9 +8070,6 @@ void qed_dbg_pf_init(struct ecore_dev *edev)
OSAL_MUTEX_INIT(&edev->dbg_lock);
- /* Sync ver with debugbus qed code */
- qed_dbg_set_app_ver(TOOLS_VERSION);
-
/* Debug values are after init values.
* The offset is the first dword of the file.
*/
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-10-27 11:43:54.985288055 +0000
+++ 0032-net-qede-remove-unused-variable.patch 2026-10-27 11:43:53.530059944 +0000
@@ -1 +1 @@
-From d497820350b9dda74ed622440efe704fc7f22a48 Mon Sep 17 00:00:00 2001
+From f76ec6c9cc3d241d74b6154ec6eb2c03ce5e01dd Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d497820350b9dda74ed622440efe704fc7f22a48 ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 1d3147b724..d14ef93a3c 100644
+index 1d3147b7248..d14ef93a3ca 100644
More information about the stable
mailing list