patch 'examples/qos_sched: fix unused variables' has been queued to stable release 24.11.9

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Oct 27 12:48:47 CET 2026


Hi,

FYI, your patch has been queued to stable release 24.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/d01d21036fdefa85fbf0e99beed549bbf4bb8244

Thanks.

Luca Boccassi

---
>From d01d21036fdefa85fbf0e99beed549bbf4bb8244 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 3 Sep 2026 12:04:03 -0700
Subject: [PATCH] examples/qos_sched: fix unused variables

[ upstream commit bade69e754aa118cf1c4d6266d3ffba919a45a60 ]

The QoS sched example tracks numa and port mask but never
uses them. Remove the dead code.

clang 23 reports:
qos_sched/args.c:26:17: error: variable 'app_numa_mask' set but not used
	 [-Werror,-Wunused-but-set-global]

Fixes: de3cfa2c9823 ("sched: initial import")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 examples/qos_sched/args.c | 5 -----
 examples/qos_sched/init.c | 1 -
 2 files changed, 6 deletions(-)

diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 886542b3c16..04e2a0e03ca 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -23,8 +23,6 @@
 #define SYS_CPU_DIR "/sys/devices/system/cpu/cpu%u/topology/"
 
 static uint32_t app_main_core = 1;
-static uint32_t app_numa_mask;
-static uint64_t app_used_port_mask = 0;
 static uint64_t app_used_rx_port_mask = 0;
 static uint64_t app_used_tx_port_mask = 0;
 
@@ -214,7 +212,6 @@ app_parse_flow_conf(const char *conf_str)
 		return -1;
 	}
 	app_used_rx_port_mask |= mask;
-	app_used_port_mask |= mask;
 
 	mask = 1lu << pconf->tx_port;
 	if (app_used_tx_port_mask & mask) {
@@ -223,7 +220,6 @@ app_parse_flow_conf(const char *conf_str)
 		return -1;
 	}
 	app_used_tx_port_mask |= mask;
-	app_used_port_mask |= mask;
 
 	nb_pfc++;
 
@@ -404,7 +400,6 @@ app_parse_args(int argc, char **argv)
 			RTE_LOG(ERR, APP, "pfc %u: RX and WT must be on the same socket\n", i + 1);
 			return -1;
 		}
-		app_numa_mask |= 1 << rte_lcore_to_socket_id(qos_conf[i].rx_core);
 	}
 
 	return 0;
diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c
index ace7279c677..d22f260430c 100644
--- a/examples/qos_sched/init.c
+++ b/examples/qos_sched/init.c
@@ -19,7 +19,6 @@
 #include "main.h"
 #include "cfg_file.h"
 
-uint32_t app_numa_mask = 0;
 static uint32_t app_inited_port_mask = 0;
 
 int app_pipe_to_profile[MAX_SCHED_SUBPORTS][MAX_SCHED_PIPES];
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-10-27 11:43:55.025942431 +0000
+++ 0033-examples-qos_sched-fix-unused-variables.patch	2026-10-27 11:43:53.530059944 +0000
@@ -1 +1 @@
-From bade69e754aa118cf1c4d6266d3ffba919a45a60 Mon Sep 17 00:00:00 2001
+From d01d21036fdefa85fbf0e99beed549bbf4bb8244 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit bade69e754aa118cf1c4d6266d3ffba919a45a60 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index 886542b3c1..04e2a0e03c 100644
+index 886542b3c16..04e2a0e03ca 100644
@@ -60 +61 @@
-index 561f9e0619..9f4b2e0082 100644
+index ace7279c677..d22f260430c 100644


More information about the stable mailing list