patch 'net/ixgbe: fix close return' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue Oct 27 12:49:28 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/eee1dc7d61a080b843ca4e79c52e857cf9b0d0a6
Thanks.
Luca Boccassi
---
>From eee1dc7d61a080b843ca4e79c52e857cf9b0d0a6 Mon Sep 17 00:00:00 2001
From: Sid Ali Cherrati <scherrati1 at gmail.com>
Date: Wed, 15 Jul 2026 14:48:16 +0200
Subject: [PATCH] net/ixgbe: fix close return
[ upstream commit 4cf8823d436b92fd342a59680a19b48006944cd7 ]
rte_intr_callback_unregister() returns the number of unregistered
callbacks on success. Since the close operation started returning
the ret variable instead of 0, this positive value leaks as the
return value of ixgbe_dev_close(), so applications checking
rte_eth_dev_close() != 0 treat a successful close as a failure.
Use a separate cb_ret variable for the unregister return value so a
successful unregister never clobbers the dev_stop() error already
stored in ret, and stop retrying once unregister fails with anything
other than -EAGAIN, since those errors are not transient.
Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int")
Signed-off-by: Sid Ali Cherrati <scherrati1 at gmail.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 91d90460978..bf6906415d2 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3106,14 +3106,17 @@ ixgbe_dev_close(struct rte_eth_dev *dev)
rte_intr_disable(intr_handle);
do {
- ret = rte_intr_callback_unregister(intr_handle,
+ int cb_ret = rte_intr_callback_unregister(intr_handle,
ixgbe_dev_interrupt_handler, dev);
- if (ret >= 0 || ret == -ENOENT) {
+ if (cb_ret >= 0 || cb_ret == -ENOENT) {
break;
- } else if (ret != -EAGAIN) {
+ } else if (cb_ret != -EAGAIN) {
PMD_INIT_LOG(ERR,
"intr callback unregister failed: %d",
- ret);
+ cb_ret);
+ if (ret == 0)
+ ret = cb_ret;
+ break;
}
rte_delay_ms(100);
} while (retries++ < (10 + IXGBE_LINK_UP_TIME));
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-10-27 11:43:56.557589135 +0000
+++ 0074-net-ixgbe-fix-close-return.patch 2026-10-27 11:43:53.586061678 +0000
@@ -1 +1 @@
-From 4cf8823d436b92fd342a59680a19b48006944cd7 Mon Sep 17 00:00:00 2001
+From eee1dc7d61a080b843ca4e79c52e857cf9b0d0a6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4cf8823d436b92fd342a59680a19b48006944cd7 ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
- drivers/net/intel/ixgbe/ixgbe_ethdev.c | 11 +++++++----
+ drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++----
@@ -26,5 +27,5 @@
-diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
-index cbb7b4831c..8d089a8063 100644
---- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
-+++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
-@@ -3024,14 +3024,17 @@ ixgbe_dev_close(struct rte_eth_dev *dev)
+diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
+index 91d90460978..bf6906415d2 100644
+--- a/drivers/net/ixgbe/ixgbe_ethdev.c
++++ b/drivers/net/ixgbe/ixgbe_ethdev.c
+@@ -3106,14 +3106,17 @@ ixgbe_dev_close(struct rte_eth_dev *dev)
More information about the stable
mailing list