patch 'net/iavf: fix null dereference in eCPRI FDIR pattern' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue Oct 27 12:49:29 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/b5937a3045030762396d4f122c6673e646790c80
Thanks.
Luca Boccassi
---
>From b5937a3045030762396d4f122c6673e646790c80 Mon Sep 17 00:00:00 2001
From: Sandeep Penigalapati <sandeep.penigalapati at intel.com>
Date: Sun, 19 Jul 2026 20:34:12 -0400
Subject: [PATCH] net/iavf: fix null dereference in eCPRI FDIR pattern
[ upstream commit f9d5e28e8bdb08cdfde3c07d57f973cfdc2955cc ]
In iavf_fdir_parse_pattern(), the RTE_FLOW_ITEM_TYPE_ECPRI case reads
ecpri_spec->hdr.common.u32 before checking that ecpri_spec is non-null.
A wildcard eCPRI flow item (no spec) with a queue or drop action, which
routes the rule to the FDIR engine, leaves item->spec as null, so the
unconditional dereference crashes the application at rule creation.
Move the ecpri_common read inside the existing "if (ecpri_spec &&
ecpri_mask)" guard, mirroring the other pattern items and the RSS-hash
parser in iavf_hash.c which already handles a null eCPRI spec. The rule
is then rejected cleanly with -EINVAL.
Fixes: 6c37927479be ("net/iavf: support eCPRI message type 0 for flow director")
Signed-off-by: Sandeep Penigalapati <sandeep.penigalapati at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
drivers/net/iavf/iavf_fdir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c
index 32134642546..fcaf0dbed4a 100644
--- a/drivers/net/iavf/iavf_fdir.c
+++ b/drivers/net/iavf/iavf_fdir.c
@@ -1441,13 +1441,13 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
ecpri_spec = item->spec;
ecpri_mask = item->mask;
- ecpri_common.u32 = rte_be_to_cpu_32(ecpri_spec->hdr.common.u32);
-
hdr = &hdrs->proto_hdr[layer];
VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, ECPRI);
if (ecpri_spec && ecpri_mask) {
+ ecpri_common.u32 = rte_be_to_cpu_32(ecpri_spec->hdr.common.u32);
+
if (ecpri_common.type == RTE_ECPRI_MSG_TYPE_IQ_DATA &&
ecpri_mask->hdr.type0.pc_id == UINT16_MAX) {
input_set |= IAVF_ECPRI_PC_RTC_ID;
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-10-27 11:43:56.595679300 +0000
+++ 0075-net-iavf-fix-null-dereference-in-eCPRI-FDIR-pattern.patch 2026-10-27 11:43:53.586061678 +0000
@@ -1 +1 @@
-From f9d5e28e8bdb08cdfde3c07d57f973cfdc2955cc Mon Sep 17 00:00:00 2001
+From b5937a3045030762396d4f122c6673e646790c80 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f9d5e28e8bdb08cdfde3c07d57f973cfdc2955cc ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
- drivers/net/intel/iavf/iavf_fdir.c | 4 ++--
+ drivers/net/iavf/iavf_fdir.c | 4 ++--
@@ -26,5 +27,5 @@
-diff --git a/drivers/net/intel/iavf/iavf_fdir.c b/drivers/net/intel/iavf/iavf_fdir.c
-index ea620863ca..67003183bb 100644
---- a/drivers/net/intel/iavf/iavf_fdir.c
-+++ b/drivers/net/intel/iavf/iavf_fdir.c
-@@ -1271,13 +1271,13 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
+diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c
+index 32134642546..fcaf0dbed4a 100644
+--- a/drivers/net/iavf/iavf_fdir.c
++++ b/drivers/net/iavf/iavf_fdir.c
+@@ -1441,13 +1441,13 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
More information about the stable
mailing list