[PATCH v2] examples/l3fwd: fix compilation when DP debug on

[Andrei Petre]

On Tue, Sep 8, 2026, 9:10 PM Stephen Hemminger <stephen at networkplumber.org>
wrote:

> On Fri, 31 Jul 2026 16:37:39 +0300
> Andrei-Niculae Petre <p31andrei at gmail.com> wrote:
>
> > Update l3fwd example app to fix compilation when building dpdk with
> > RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG in config/rte_config.h .
> > Move l3fwd_acl.h include above all #ifdef L3FWDACL_DEBUG checks,
> > as previously one ifdef would evaluate to false all the time (as
> > header include was added too late).
> >
> > Adapt maintainers line from previous examples/l3fwd-acl (removed in
> > 6de0ea50e9b9) to examples/l3fwd/l3fwd_acl* after l3fwd-acl app
> > unification into l3fwd. In 6de0ea50e9b9, a line with maintainer
> > expertise was removed.
> >
> > Own testing of the l3fwd example:
> > 1. It now compiles with "#define RTE_LOG_DP_LEVEL RTE_LOG_DEBUG" in
> >    config/rte_config.h. See Bugzilla ID 1318 comments for full error
> >    seen before this patch.
> > 2. I ran the l3fwd app with IPv4/IPv6 ACL rules to see the prints (when
> >    RTE_LOG_DP_LEVEL RTE_LOG_DEBUG is set) in the application around ACL
> >    work as expected. See extract below (I added \ to format to 72chars):
> >
> > // dump_acl4_rule extract:
> > Packet Src:192.168.1.100 Dst:192.168.1.101 Src port:2048,Dst port:1846 \
> > hit ACL 1 - 192.168.1.100/24 0.0.0.0/0 0 : 65535 0 : 65535 0x0/0x0 \
> > 0xffffffff-0x1ffffffe-0xf0000001
> >
> > // dump_acl6_rule extract:
> > Packet Src2001:db8:1::100
> > Dst2001:db8:1::101
> > Src port:32768,Dst port:21005 hit ACL 0 - \
> > 2001:0db8:0001:0000:0000:0000:0000:0000/64 \
> > 0000:0000:0000:0000:0000:0000:0000:0000/0 0 : 65535 0 : 65535 \
> > 0x0/0x0 0xffffffff-0x1fffffff-0xf0000000
> >
> > Bugzilla ID: 1318
> > Fixes: 6de0ea50e9b9 ("examples/l3fwd: merge l3fwd-acl example")
> > Cc: stable at dpdk.org
> > Cc: sean.morrissey at intel.com
> >
> > Signed-off-by: Andrei-Niculae Petre <p31andrei at gmail.com>
> > ---
>
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e99a65d197..6b6446a998 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1756,6 +1756,8 @@ F: lib/acl/
> >  F: doc/guides/prog_guide/packet_classif_access_ctrl.rst
> >  F: app/test-acl/
> >  F: app/test/test_acl.*
> > +F: examples/l3fwd/l3fwd_acl*
> > +F: doc/guides/sample_app_ug/l3_forward.rst
>
> I don't think all of l3_forward should fall under the ACL maintainer
> bucket.
>

Hi Stephen,

I totally agree, but I didn't know of a better way to do this given all the
info was merged in a single file post l3fwd unification. Do you or
Konstantin have any better ideas how to do this instead to avoid losing
information re ACL maintainer?

Thanks for checking the patch also.

Andrei

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/stable/attachments/20260908/7b8b5336/attachment.htm>