[dpdk-test-report] |WARNING| pw44501 [30/37] net/sfc/base: add support to get active FEC type

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Sep 10 11:40:28 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44501

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#44: FILE: drivers/net/sfc/base/ef10_impl.h:636:
+extern	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#45: FILE: drivers/net/sfc/base/ef10_impl.h:637:
+ef10_phy_fec_type_get(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#151: FILE: drivers/net/sfc/base/ef10_phy.c:546:
+ef10_phy_fec_type_get(

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#159: FILE: drivers/net/sfc/base/ef10_phy.c:554:
+	if ((rc = ef10_phy_get_link(enp, &els)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#164: FILE: drivers/net/sfc/base/ef10_phy.c:559:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#169: FILE: drivers/net/sfc/base/ef10_phy.c:564:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#191: FILE: drivers/net/sfc/base/efx.h:3212:
+efx_phy_fec_type_get(

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#206: FILE: drivers/net/sfc/base/efx_impl.h:227:
+	efx_rc_t	(*epo_fec_type_get)(efx_nic_t *, efx_phy_fec_type_t *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_phy_fec_type_t *' should also have an identifier name
#206: FILE: drivers/net/sfc/base/efx_impl.h:227:
+	efx_rc_t	(*epo_fec_type_get)(efx_nic_t *, efx_phy_fec_type_t *);

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#234: FILE: drivers/net/sfc/base/efx_phy.c:195:
+#define	EFX_PHY_CAP_FEC_REQ_MASK			\
+	(1U << EFX_PHY_CAP_BASER_FEC_REQUESTED)	|	\
+	(1U << EFX_PHY_CAP_RS_FEC_REQUESTED)	|	\
+	(1U << EFX_PHY_CAP_25G_BASER_FEC_REQUESTED)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#261: FILE: drivers/net/sfc/base/efx_phy.c:322:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#265: FILE: drivers/net/sfc/base/efx_phy.c:326:
+efx_phy_fec_type_get(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#269: FILE: drivers/net/sfc/base/efx_phy.c:330:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#280: FILE: drivers/net/sfc/base/efx_phy.c:341:
+	if ((rc = epop->epo_fec_type_get(enp, typep)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#283: FILE: drivers/net/sfc/base/efx_phy.c:344:
+	return (0);

total: 7 errors, 2 warnings, 6 checks, 224 lines checked


More information about the test-report mailing list