[dpdk-test-report] |WARNING| pw44502 [32/37] net/sfc/base: check buffer size for hash flags

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44502

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#117: FILE: drivers/net/sfc/base/efx_rx.c:320:
+#define	INSERT_FLAGS(_flags)			\
+	do {					\
+		if (nflags >= max_nflags) {	\
+			rc = E2BIG;		\
+			goto fail2;		\
+		}				\
+		*(flagsp + nflags) = (_flags);	\
+		nflags++;			\
+						\
+		_NOTE(CONSTANTCONDITION)	\
 	} while (B_FALSE)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'encp->enc_rx_scale_l4_hash_supported != B_FALSE'
#136: FILE: drivers/net/sfc/base/efx_rx.c:337:
+	if ((encp->enc_rx_scale_l4_hash_supported != B_FALSE) &&
+	    (encp->enc_rx_scale_additional_modes_supported != B_FALSE)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'encp->enc_rx_scale_additional_modes_supported != B_FALSE'
#136: FILE: drivers/net/sfc/base/efx_rx.c:337:
+	if ((encp->enc_rx_scale_l4_hash_supported != B_FALSE) &&
+	    (encp->enc_rx_scale_additional_modes_supported != B_FALSE)) {

total: 0 errors, 1 warnings, 2 checks, 177 lines checked