[dpdk-test-report] |WARNING| pw76213 [PATCH v1 10/42] net/txgbe: add module identify

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 9 01:27:08 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76213

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#105: FILE: drivers/net/txgbe/base/txgbe_phy.c:11:
+STATIC void txgbe_i2c_stop(struct txgbe_hw *hw);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'connector ==
 				     TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE'
#401: FILE: drivers/net/txgbe/base/txgbe_phy.c:528:
+			if ((connector ==
+				     TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE) &&
+			    (cable_length > 0) &&
+			    ((device_tech >> 4) ==
+				     TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cable_length > 0'
#401: FILE: drivers/net/txgbe/base/txgbe_phy.c:528:
+			if ((connector ==
+				     TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE) &&
+			    (cable_length > 0) &&
+			    ((device_tech >> 4) ==
+				     TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL))

WARNING:TYPO_SPELLING: 'TRANSMITER' may be misspelled - perhaps 'TRANSMITTER'?
#405: FILE: drivers/net/txgbe/base/txgbe_phy.c:532:
+				     TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL))

CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#476: FILE: drivers/net/txgbe/base/txgbe_phy.c:603:
+				if (hw->allow_unsupported_sfp == true) {

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#477: FILE: drivers/net/txgbe/base/txgbe_phy.c:604:
+					DEBUGOUT(

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#690: FILE: drivers/net/txgbe/base/txgbe_phy.c:817:
+
+}

total: 0 errors, 2 warnings, 5 checks, 649 lines checked


More information about the test-report mailing list