[dpdk-test-report] |WARNING| pw76214 [PATCH v1 12/42] net/txgbe: add device start and stop

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 9 01:27:12 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76214

_coding style issues_


WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_set_mac_type', this function's name, in a string
#255: FILE: drivers/net/txgbe/base/txgbe_hw.c:382:
+	DEBUGOUT("txgbe_set_mac_type found mac: %d media: %d, returns: %d
",

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == txgbe_media_type_copper'
#466: FILE: drivers/net/txgbe/txgbe_ethdev.c:177:
+	if (err && (hw->phy.media_type == txgbe_media_type_copper)) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#474: FILE: drivers/net/txgbe/txgbe_ethdev.c:185:
+	if (err == TXGBE_ERR_EEPROM_VERSION) {
[...]
+	} else if (err == TXGBE_ERR_SFP_NOT_SUPPORTED)
[...]

total: 0 errors, 1 warnings, 2 checks, 733 lines checked


More information about the test-report mailing list