|WARNING| pw117056 [PATCH 4/5] test/security: add inline MACsec cases

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 28 14:48:18 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117056

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#303: FILE: app/test/test_security_inline_macsec.c:193:
+	 * from the test vector so that we can match the out packet. */

ERROR:C99_COMMENTS: do not use C99 // comments
#357: FILE: app/test/test_security_inline_macsec.c:247:
+//	struct rte_security_capability_idx sec_cap_idx;

ERROR:C99_COMMENTS: do not use C99 // comments
#358: FILE: app/test/test_security_inline_macsec.c:248:
+//	const struct rte_security_capability *sec_cap;

ERROR:C99_COMMENTS: do not use C99 // comments
#392: FILE: app/test/test_security_inline_macsec.c:282:
+//	sec_cap = rte_security_capability_get(sec_ctx, &sec_cap_idx);

ERROR:C99_COMMENTS: do not use C99 // comments
#393: FILE: app/test/test_security_inline_macsec.c:283:
+//	if (sec_cap == NULL) {

ERROR:C99_COMMENTS: do not use C99 // comments
#394: FILE: app/test/test_security_inline_macsec.c:284:
+//		printf("No capabilities registered
");

ERROR:C99_COMMENTS: do not use C99 // comments
#395: FILE: app/test/test_security_inline_macsec.c:285:
+//		return TEST_SKIPPED;

ERROR:C99_COMMENTS: do not use C99 // comments
#396: FILE: app/test/test_security_inline_macsec.c:286:
+//	}

total: 7 errors, 1 warnings, 3146 lines checked
Warning in app/test/test_security_inline_macsec.c:
Declaring a variable inside for()


More information about the test-report mailing list