|WARNING| pw117055 [PATCH 3/5] net/cnxk: support MACsec

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 28 14:48:24 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117055

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

ERROR:SPACING: space prohibited before that ':' (ctx:WxE)
#142: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:41:
+		default :
 		        ^

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#393: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:292:
+	ret = mcs_resource_alloc(mcs_dev, sess->dir, &(sess->flow_id), 1, CNXK_MCS_RSRC_TYPE_FLOWID);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around sess->flow_id
#393: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:292:
+	ret = mcs_resource_alloc(mcs_dev, sess->dir, &(sess->flow_id), 1, CNXK_MCS_RSRC_TYPE_FLOWID);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#421: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:320:
+		req.data[0] = (uint64_t)dst.addr_bytes[0] << 40 | (uint64_t)dst.addr_bytes[1] << 32 |

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#422: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:321:
+			      (uint64_t)dst.addr_bytes[2] << 24 | (uint64_t)dst.addr_bytes[3] << 16 |

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#426: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:325:
+			      (uint64_t)src.addr_bytes[1] << 16 | (uint64_t)src.addr_bytes[0] << 24 |

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#439: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:338:
+			      ((uint64_t)opts.num_tags & 0x7F) << 2 | ((uint64_t)opts.express & 1) << 9 |

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#693: FILE: drivers/net/cnxk/cnxk_ethdev.h:671:
+struct cnxk_mcs_dev * cnxk_mcs_dev_init(uint8_t mcs_idx);

total: 2 errors, 6 warnings, 1 checks, 594 lines checked


More information about the test-report mailing list