|WARNING| pw153387 [PATCH v10 2/3] cmdline: add floating point support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153387

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#131: FILE: app/test/test_cmdline_num.c:29:
+	const char * str;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#370: FILE: app/test/test_cmdline_num.c:620:
+			ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#371: FILE: app/test/test_cmdline_num.c:621:
+					float_invalid_strs[i], (void*)&result, sizeof(result));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#374: FILE: app/test/test_cmdline_num.c:624:
+				cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,

ERROR:CODE_INDENT: code indent should use tabs where possible
#407: FILE: app/test/test_cmdline_num.c:689:
+ ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#407: FILE: app/test/test_cmdline_num.c:689:
+ ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#407: FILE: app/test/test_cmdline_num.c:689:
+ ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#407: FILE: app/test/test_cmdline_num.c:689:
+ 			ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#426: FILE: app/test/test_cmdline_num.c:736:
+			cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#429: FILE: app/test/test_cmdline_num.c:739:
+			ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#431: FILE: app/test/test_cmdline_num.c:741:
+				(void*)&result, sizeof(result));

WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#433: FILE: app/test/test_cmdline_num.c:743:
+			/* if it should have passed but didn't, or if it should have failed but didn't */

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#471: FILE: app/test/test_cmdline_num.c:850:
+			cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#474: FILE: app/test/test_cmdline_num.c:853:
+			ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#476: FILE: app/test/test_cmdline_num.c:855:
+				(void*)&result, sizeof(result));

WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#478: FILE: app/test/test_cmdline_num.c:857:
+			/* if it should have passed but didn't, or if it should have failed but didn't */

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#479: FILE: app/test/test_cmdline_num.c:858:
+			if ((ret < 0) == (can_parse_float(float_garbage_strs[i].result, type) > 0)) {

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#485: FILE: app/test/test_cmdline_num.c:864:
+			if (ret > 0 && float_cmp(float_garbage_strs[i].result, &result, type) != 0) {

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#601: FILE: lib/cmdline/cmdline_parse_num.c:78:
+		if (ressize < sizeof(float))

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#605: FILE: lib/cmdline/cmdline_parse_num.c:82:
+		if (ressize < sizeof(double))

total: 12 errors, 8 warnings, 555 lines checked