|WARNING| pw153386 [PATCH v10 1/3] cmdline: use C standard library as number parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153386

_coding style issues_


ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#389: FILE: lib/cmdline/cmdline_parse_num.c:193:
+			}
+			else {

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#400: FILE: lib/cmdline/cmdline_parse_num.c:199:
+			if (c == '0') {
[...]
-			else  {
[...]

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#404: FILE: lib/cmdline/cmdline_parse_num.c:202:
 			}
+			else {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#404: FILE: lib/cmdline/cmdline_parse_num.c:202:
+			else {
 				st = ERROR;
 			}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#414: FILE: lib/cmdline/cmdline_parse_num.c:208:
+			if (c == 'b') {
[...]
-			else if (c >= '0' && c <= '7') {
[...]

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#621: FILE: lib/cmdline/cmdline_parse_num.c:293:
+	unsigned ressize)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#621: FILE: lib/cmdline/cmdline_parse_num.c:293:
+	unsigned ressize)

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#637: FILE: lib/cmdline/cmdline_parse_num.c:309:
+	if (res && check_res_size(&nd, ressize) < 0)

total: 2 errors, 6 warnings, 545 lines checked