|SUCCESS| [v1] dts: update modprobe command to be privileged
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Apr 3 23:10:26 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162854
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-03
commit 1175f18ab85d
Author: Andrew Bailey <abailey at iol.unh.edu>
Subject: dts: update modprobe command to be privileged
The command to modprobe VFIO-PCI will not work without a privileged
command. This patch makes this change.
> diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py
> index ee943462c2..63856ad9b5 100644
> --- a/dts/framework/testbed_model/linux_session.py
> +++ b/dts/framework/testbed_model/linux_session.py
> @@ -245,7 +245,7 @@ def load_vfio(self, pf_port: Port) -> None:
> privileged=True,
> )
> else:
> - self.send_command("modprobe vfio-pci")
> + self.send_command("modprobe vfio-pci", privileged=True)
> self.refresh_lshw()
This fix looks correct. The privileged=True parameter is needed for
modprobe operations requiring root access. The if branch already uses
privileged=True, and the else branch should be consistent.
More information about the test-report
mailing list