|SUCCESS| [v1] dts: update modprobe command to be privileged

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162854

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-03

Reviewed patch at commit for modprobe command privilege fix.

Author: Andrew Bailey <abailey at iol.unh.edu>
Subject: [PATCH v1] dts: update modprobe command to be privileged

The patch updates the modprobe vfio-pci command to execute with
privileged permissions, addressing Bugzilla 1924 where the command would
fail without proper privileges.

> diff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py
> index ee943462c2..63856ad9b5 100644
> --- a/dts/framework/testbed_model/linux_session.py
> +++ b/dts/framework/testbed_model/linux_session.py
> @@ -245,7 +245,7 @@ def load_vfio(self, pf_port: Port) -> None:
>                  privileged=True,
>              )
>          else:
> -            self.send_command("modprobe vfio-pci")
> +            self.send_command("modprobe vfio-pci", privileged=True)
>          self.refresh_lshw()

The change looks correct for making modprobe require privileges. However,
does this code path handle the case where modprobe fails? Looking at the
context, the if-branch handles vfio enablement with privileged=True, but
does send_command() in the else-branch raise an exception on failure?
Without error checking, a failed modprobe would silently continue to
refresh_lshw().

Is there error handling elsewhere that catches modprobe failures, or
should this code verify the module loaded successfully before proceeding?