|SUCCESS| net/ice: add missing SMAC field mapping in flow input set

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162858

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-06

I'll review this patch against the DPDK coding standards and guidelines.

commit 733640dae75e ("net/ice: support L2TPv2 flow pattern matching")
Author: Shaiq Wani <shaiq.wani at intel.com>

[PATCH] net/ice: add missing SMAC field mapping in flow input set

This patch adds a missing entry for source MAC address (SMAC) to the
ice_inset_map[] array in the ICE PMD's flow director filter code.
Without this entry, source MAC addresses specified in flow rules are not
properly translated to the hardware field index, causing flow rules to
silently match any source address instead of the specified one.

> diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
> index 3522d77123..b3fdb1a9d7 100644
> --- a/drivers/net/intel/ice/ice_fdir_filter.c
> +++ b/drivers/net/intel/ice/ice_fdir_filter.c
> @@ -967,6 +967,7 @@ ice_fdir_input_set_parse(uint64_t inset, enum ice_flow_field *field)
>  	};
>  	static const struct ice_inset_map ice_inset_map[] = {
>  		{ICE_INSET_DMAC, ICE_FLOW_FIELD_IDX_ETH_DA},
> +		{ICE_INSET_SMAC, ICE_FLOW_FIELD_IDX_ETH_SA},
>  		{ICE_INSET_ETHERTYPE, ICE_FLOW_FIELD_IDX_ETH_TYPE},
>  		{ICE_INSET_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA},
>  		{ICE_INSET_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA},

The patch looks correct. The missing SMAC entry in ice_inset_map[] would
indeed prevent proper translation of source MAC addresses in flow rules.
The fix properly adds the mapping between ICE_INSET_SMAC and
ICE_FLOW_FIELD_IDX_ETH_SA, following the same pattern as the existing
DMAC entry immediately above it.

The placement is logical, keeping the Ethernet-related fields grouped
together at the beginning of the array. The code follows DPDK coding
style requirements with proper indentation and formatting.