|SUCCESS| net/ice: add missing SMAC field mapping in flow input set
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Wed Apr 8 23:34:05 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162858
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-08
commit 1a2b3c4d5e6f7890abcdef1234567890abcdef12
Author: Shaiq Wani <shaiq.wani at intel.com>
net/ice: add missing SMAC field mapping in flow input set
This patch fixes a bug where source MAC address matching in flow rules
was silently ignored. The ice_inset_map[] array was missing the mapping
entry for ICE_INSET_SMAC, causing flow rules that specified a source MAC
address to match any source address instead.
> diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
> index 3522d77123..b3fdb1a9d7 100644
> --- a/drivers/net/intel/ice/ice_fdir_filter.c
> +++ b/drivers/net/intel/ice/ice_fdir_filter.c
> @@ -967,6 +967,7 @@ ice_fdir_input_set_parse(uint64_t inset, enum ice_flow_field *field)
> };
> static const struct ice_inset_map ice_inset_map[] = {
> {ICE_INSET_DMAC, ICE_FLOW_FIELD_IDX_ETH_DA},
> + {ICE_INSET_SMAC, ICE_FLOW_FIELD_IDX_ETH_SA},
> {ICE_INSET_ETHERTYPE, ICE_FLOW_FIELD_IDX_ETH_TYPE},
> {ICE_INSET_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA},
> {ICE_INSET_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA},
The patch looks correct. The missing ICE_INSET_SMAC entry in the
ice_inset_map[] array would indeed cause source MAC address matching to
fail silently. Adding the mapping entry resolves this issue.
The placement of the new entry immediately after ICE_INSET_DMAC maintains
logical ordering and aligns with the existing structure of the array.
More information about the test-report
mailing list