|SUCCESS| net/ice: add missing SMAC field mapping in flow input set

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162858

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-09

Commit: 733640dae75e ("net/ice: support L2TPv2 flow pattern matching")
Author: Shaiq Wani <shaiq.wani at intel.com>
Subject: [PATCH] net/ice: add missing SMAC field mapping in flow input set

This patch adds a missing entry for source MAC address (SMAC) in the
ice_inset_map[] array. Without this entry, flow rules specifying a
source MAC address would silently match any source address instead of
the specified one.

> diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
> index 3522d77123..b3fdb1a9d7 100644
> --- a/drivers/net/intel/ice/ice_fdir_filter.c
> +++ b/drivers/net/intel/ice/ice_fdir_filter.c
> @@ -967,6 +967,7 @@ ice_fdir_input_set_parse(uint64_t inset, enum ice_flow_field *field)
>  	};
>  	static const struct ice_inset_map ice_inset_map[] = {
>  		{ICE_INSET_DMAC, ICE_FLOW_FIELD_IDX_ETH_DA},
> +		{ICE_INSET_SMAC, ICE_FLOW_FIELD_IDX_ETH_SA},
>  		{ICE_INSET_ETHERTYPE, ICE_FLOW_FIELD_IDX_ETH_TYPE},
>  		{ICE_INSET_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA},
>  		{ICE_INSET_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA},

The patch looks correct and addresses a genuine bug where source MAC
filtering would not work. The fix is minimal and follows the existing
pattern in the ice_inset_map[] array.

However, does the Fixes tag reference the correct commit? The commit
733640dae75e added L2TPv2 support, but this SMAC mapping issue appears
to be a pre-existing problem that likely dates back to when the
ice_inset_map[] was originally created. Can you verify that commit
733640dae75e is truly when this mapping was introduced or when SMAC
support was expected to work?

Also, should this fix be accompanied by a test case or mention in the
release notes to document the behavior change, given that flows with
SMAC specifications were silently failing before this fix?