|SUCCESS| net/gve: enable comma warnings

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162950

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-09

From: Stephen Hemminger <stephen at networkplumber.org>
Subject: [PATCH] net/gve: enable comma warnings

This driver has no misuse of comma operator in current version.

[ ... ]

> diff --git a/drivers/net/gve/meson.build b/drivers/net/gve/meson.build
> index 11560056b9..e93dd2e270 100644
> --- a/drivers/net/gve/meson.build
> +++ b/drivers/net/gve/meson.build
> @@ -21,4 +21,3 @@ sources = files(
>  includes += include_directories('base')
>  
>  cflags += no_wvla_cflag
> -cflags += no_comma_cflag

Does this line removal enable or disable comma warnings? The commit
subject says "enable comma warnings" but removing the no_comma_cflag
line would seem to disable the flag that disables comma warnings. Can
you clarify whether no_comma_cflag suppresses the comma warnings, or
enables them?

If no_comma_cflag is defined as '-Wno-comma' somewhere in the build
system, then removing this line would indeed enable the warnings as the
subject claims. However, if no_comma_cflag is defined as '-Wcomma', then
removing it would disable warnings, making the commit message incorrect.

Can you verify how no_comma_cflag is defined in the DPDK build system to
confirm this change matches the commit message?