|SUCCESS| net/gve: enable comma warnings
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Thu Apr 9 05:40:14 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162950
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-09
**Commit:** (SHA needed from git log)
**Author:** Stephen Hemminger <stephen at networkplumber.org>
**Subject:** [PATCH] net/gve: enable comma warnings
**Summary:**
This patch removes the `-Wno-comma` compiler flag from the GVE network
driver's build configuration, enabling comma operator warnings that were
previously suppressed.
**Diff:**
> diff --git a/drivers/net/gve/meson.build b/drivers/net/gve/meson.build
> index 11560056b9..e93dd2e270 100644
> --- a/drivers/net/gve/meson.build
> +++ b/drivers/net/gve/meson.build
> @@ -21,4 +21,3 @@ sources = files(
> includes += include_directories('base')
>
> cflags += no_wvla_cflag
> -cflags += no_comma_cflag
**Questions:**
In the line being removed, does the variable `no_comma_cflag` still exist
and remain defined somewhere in the DPDK build system? If this flag is no
longer needed because comma operator issues were fixed, should there be
verification that all source files in this driver actually compile cleanly
with `-Wcomma` enabled? Were any comma operator fixes made in prior
commits that make this change safe?
More information about the test-report
mailing list